feat(node)!: Use db.query and db span ops for Redis - #22690
Merged
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/js-3105-redis-db-ops
branch
2 times, most recently
from
July 27, 2026 14:59
255327a to
abf5234
Compare
The datastore belongs in `db.system.name`, not the op. Commands and batches use `db.query`, connects use `db`. Command spans now also set `db.operation.name`. Cache-classified spans keep their `cache.*` ops. Ref: JS-3105 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
msonnb
force-pushed
the
ms/js-3105-redis-db-ops
branch
from
July 29, 2026 09:46
abf5234 to
c793917
Compare
msonnb
requested review from
a team,
isaacs and
mydea
and removed request for
a team
July 29, 2026 09:46
msonnb
marked this pull request as ready for review
July 29, 2026 09:47
isaacs
approved these changes
Jul 29, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
LGTM, apart from the merge conflict, of course. 👍
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f09a103. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands and batches use
db.queryinstead ofdb.redis; connect spans usedbinstead ofdb.redis.connect. The datastore is already identified bydb.system.name=redis, so the library-specific op leaf was redundant.Command spans in the DC subscriber now also set
db.operation.name— the command was only indb.query.textbefore.Two command paths in
tracing-channel/redis.tswere already emitting a baredb; those becomedb.querytoo, since they carry a statement. Redis used as a cache keeps itscache.*ops (that classification happens in the response hook and is unaffected).Part of #22446